id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc	uname	nginx_version
1482	Memory leak in error handling block in ngx_stream_geo_block method	keeplearning77@…	Ruslan Ermilov	"Source: nginx-1.13.8

File: nginx-1.13.8/src/stream/ngx_stream_geo_module.c

Function: static char *
ngx_stream_geo_block(ngx_conf_t *cf, ngx_command_t *cmd, void *conf)

Code snippet:
    ...
    ...
    pool = ngx_create_pool(NGX_DEFAULT_POOL_SIZE, cf->log);
    if (pool == NULL) {
        return NGX_CONF_ERROR;
    }

    ngx_memzero(&ctx, sizeof(ngx_stream_geo_conf_ctx_t));

    ctx.temp_pool = ngx_create_pool(NGX_DEFAULT_POOL_SIZE, cf->log);
    if (ctx.temp_pool == NULL) {
        return NGX_CONF_ERROR;
    }

    ...

Here, if the creation of ctx.temp_pool fails, shouldn't the ""pool"" variable created above be freed before return?"	defect	closed	minor		other	1.13.x	fixed				nginx-1.13.8