Changes between Initial Version and Version 1 of Ticket #1928, comment 7


Ignore:
Timestamp:
02/03/20 20:04:32 (21 months ago)
Author:
val-kulkov@…

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1928, comment 7

    initial v1  
    1010The way I see it, 101-feature_test_fix.patch and 103-sys_nerr.patch are harmless and IMO they could not possibly be the culprits. The 200 and 300 series patches do not modify the code. They only modify configuration files and therefore they are not suspects.
    1111
    12 102-sizeof_test_fix.patch is a possible suspect, but it looks okay to me. It uses a clever hack to determine the size of int. Here is the relevant part of auto/types/sizeof after applying the patch:
     12102-sizeof_test_fix.patch is a possible suspect, but it looks okay to me. It uses a clever hack to determine the size of $ngx_type. Here is the relevant part of auto/types/sizeof after applying the patch:
    1313
    1414{{{
     
    5151
    5252
    53 Note that it is the ('0' + sizeof($ngx_type)) construct in object_code_block[] that is used to determine the size of int. "sed" utility then looks for the sequence of characters defined in object_code_block and obtains value of ('0' + sizeof($ngx_type)). Do you see any issue with this approach?
     53Note that it is the ('0' + sizeof($ngx_type)) construct in object_code_block[] that is used to determine the size of $ngx_type. "sed" utility then looks for the sequence of characters defined in object_code_block and obtains value of ('0' + sizeof($ngx_type)). Do you see any issue with this approach?