nginx should reliably check client connection close with pending data
|Reported by:||Sergey Kandaurov||Owned by:||Valentin V. Bartenev|
Description (last modified by Maxim Dounin)
To detect if a connection was closed by a client, nginx uses:
- A EV_EOF flag as reported by kqueue. This only works if you use kqueue, i.e. on FreeBSD and friends.
- The recv(MSG_PEEK) call to test a case when connection was closed. This works on all platforms, but only if there are no pending data.
Most notably, this doesn't cover Linux and SSL connections, which are usually closed with pending data (a shutdown alert). To improve things, the following should be implemented (in no particular order):
- SSL_peek() for SSL connections instead of recv(MSG_PEEK), likely with additional c->peek() call.
- Support for EPOLLRDHUP, which is believed to be close to EV_EOF provided by kqueue.
Change History (7)
comment:2 Changed 2 years ago by Valentin V. Bartenev
- Owner set to vbart
- Status changed from new to assigned