Custom Query (2296 matches)

See ​http://mailman.nginx.org/pipermail/nginx-devel/2011-September/001260.html for lots of detail but the TL;DR is

When

proxy_cache_bypass $http_pragma;

Is set. When a shift reload is performed we set the object as cacheable after we have checked for the privacy headers. So we cache it when we shouldn't.

Possible patch attached

Hi.

For the Debian packaging purposes, I try to make Nginx working under the hurd-i386 kernel.

The error is the following.

gcc -c -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Wunused-function -Wunused-variable -Wunused-value -Werror -g  -I src/core -I src/event -I src/event/modules -I src/os/unix -I /usr/include/libxml2 -I objs -I src/http -I src/http/modules \
                -o objs/src/http/ngx_http_variables.o \
                src/http/ngx_http_variables.c
src/http/ngx_http_variables.c: In function ‘ngx_http_variable_realpath_root’:
src/http/ngx_http_variables.c:1160:37: error: ‘PATH_MAX’ undeclared (first use in this function)
src/http/ngx_http_variables.c:1160:37: note: each undeclared identifier is reported only once for each function it appears in
src/http/ngx_http_variables.c:1160:32: error: unused variable ‘real’ [-Werror=unused-variable]
cc1: all warnings being treated as error

Under hurd, there is no PATH_MAX variable defined in the limits.h kernel header, and in any other header.

In order to have this issue corrected, I decided to set the PATH_MAX at 4096 (which is the common value in most Linux based systems). And after this, the build is working fine.

I attached a patch which does the trick.

I would like this patch to be applied upstream, as it will benefit all distributions providing a hurd kernel.

I'm working on the last version (1.1.4), and it can be applied/adapted on any other serie (1.0.x and 0.8.x), as Nginx always failed to build under hurd-i386.

Thanks.

Hi.

On Debian packaging, we decided to include the MP4 module as it could be very usefull.

The build goes well on all architectures, except hurd-i386.

Here is the error

gcc -c -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Wunused-function -Wunused-variable -Wunused-value -Werror -g  -DNDK_SET_VAR -I src/core -I src/event -I src/event/modules -I src/os/unix -I /root/orig/nginx-1.1.4/debian/modules/nginx-development-kit/objs -I objs/addon/ndk -I /usr/include/lua5.1 -I /root/orig/nginx-1.1.4/debian/modules/nginx-http-push/src -I /usr/include/libxml2 -I objs -I src/http -I src/http/modules -I src/http/modules/perl -I /root/orig/nginx-1.1.4/debian/modules/nginx-development-kit/src \
                -o objs/src/http/modules/ngx_http_mp4_module.o \
                src/http/modules/ngx_http_mp4_module.c
src/http/modules/ngx_http_mp4_module.c: In function ‘ngx_http_mp4_update_mdat_atom’:
src/http/modules/ngx_http_mp4_module.c:1069:24: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
src/http/modules/ngx_http_mp4_module.c:1072:9: error: right shift count >= width of type [-Werror]
src/http/modules/ngx_http_mp4_module.c:1072:9: error: right shift count >= width of type [-Werror]
src/http/modules/ngx_http_mp4_module.c:1072:9: error: right shift count >= width of type [-Werror]
src/http/modules/ngx_http_mp4_module.c:1072:9: error: right shift count >= width of type [-Werror]
src/http/modules/ngx_http_mp4_module.c: In function ‘ngx_http_mp4_update_co64_atom’:
src/http/modules/ngx_http_mp4_module.c:2764:5: error: right shift count >= width of type [-Werror]
src/http/modules/ngx_http_mp4_module.c:2764:5: error: right shift count >= width of type [-Werror]
src/http/modules/ngx_http_mp4_module.c:2764:5: error: right shift count >= width of type [-Werror]
src/http/modules/ngx_http_mp4_module.c:2764:5: error: right shift count >= width of type [-Werror]
cc1: all warnings being treated as errors

make[2]: *** [objs/src/http/modules/ngx_http_mp4_module.o] Error 1

So I went on the search and use my little C coding knowledge, and I arrived to resolve the first error ("src/http/modules/ngx_http_mp4_module.c:1069:24: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]"), using the patch attached to this ticket.

But for the remaining error, I'm a little lost, and the only thing I know is I have to patch the ngx_mp4_set_64value function, declared at line 189.

At this point, I'm unable to find a solution.

For the moment, we are working on disabling this module for the hurd-i386 arch, which is not what we like to do.

So if anybody upstream can help me resolve this issue, we can work together.

Thanks