Custom Query (2297 matches)

Hi,

This issue would be out of AMI-Support range. However, I would like to know if this is a bug before creating new ticket on 'nignx.org'.

When I set 'ri' and 'rs' parameters together, the value of 'rs' is not applied. When client requests as an below example with a following configuration, 'limit_rate_after', which is dependent on 'rs' parameter,does not work.

Configuation

server {
        server_name test-domain.com
        root    /htdocs;

        location ~* \.flv {
            flv;
            if ($arg_LRA) {
                set $limit_rate_after $arg_LRA;
            }
            if ($arg_LR) {
                set $limit_rate "${arg_LR}k";
            }
        }
    }

Example of client request

curl -o /dev/null -H "Host: test-domain.com" http://localhost/test.flv?ri=100&rs=8192000

The result of client request shows that 'limit_rate' 100k has worked but limit_rate_after 8192000 has not worked.

I assumed that this is bug, so I've adjusted attached patch file which are modified below files.

./src/http/ngx_http_request.h
./src/http/ngx_http_variables.c
./src/http/ngx_http_write_filter_module.c

I would like to know if there is a problem in my configuration or it is bug.

I don't know if it's something to be excepted or if it's really a bug.

My conf (in a server {}):

location ~ /socket {
  proxy_pass http://unix:/tmp/app.socket;
  proxy_http_version 1.1;
  proxy_set_header Upgrade "websocket";
  proxy_set_header Connection "upgrade";
}

error.log:

2013/03/26 15:25:11 [alert] 21581#0: *3457 
setsockopt(TCP_NODELAY) failed 
(102: Operation not supported on socket) while proxying upgraded connection, 
client: 127.0.0.1, 
server: localhost, 
request: "GET /socket/230/5o96b2yn/websocket HTTP/1.1",
upstream: "http://unix:/tmp/app.socket:/socket/230/5o96b2yn/websocket", 
host: "localhost"

It works perfectly fine if I replace proxy_pass http://unix:/tmp/app.socket; with proxy_pass http://127.0.0.1:9000; (and make accordingly the change on my socket server to listen on port 9000).

% valgrind --tool=memcheck --track-origins=yes --malloc-fill=7E ~/nginx/sbin/nginx -p $(pwd)/t/servroot/ -c $(pwd)/t/servroot/conf/nginx.conf
==3476== Memcheck, a memory error detector
==3476== Copyright (C) 2002-2010, and GNU GPL'd, by Julian Seward et al.
==3476== Using Valgrind-3.6.1 and LibVEX; rerun with -h for copyright info
==3476== Command: /home/maage/nginx/sbin/nginx -p /home/maage/a/nginx-1.2.9/t/servroot/ -c /home/maage/a/nginx-1.2.9/t/servroot/conf/nginx.conf
==3476==
==3476== Syscall param pwrite64(buf) points to uninitialised byte(s)
==3476==    at 0x3B1980EEF3: __pwrite_nocancel (in /lib64/libpthread-2.14.90.so)
==3476==    by 0x41DBD0: ngx_write_file (ngx_files.c:80)
==3476==    by 0x41DDB9: ngx_write_chain_to_file (ngx_files.c:209)
==3476==    by 0x40AB7E: ngx_write_chain_to_temp_file (ngx_file.c:36)
==3476==    by 0x41C04A: ngx_event_pipe_write_chain_to_temp_file (ngx_event_pipe.c:753)
==3476==    by 0x41D351: ngx_event_pipe (ngx_event_pipe.c:441)
==3476==    by 0x43F23D: ngx_http_upstream_process_upstream (ngx_http_upstream.c:2663)
==3476==    by 0x4411E3: ngx_http_upstream_process_header (ngx_http_upstream.c:2362)
==3476==    by 0x43F3A4: ngx_http_upstream_handler (ngx_http_upstream.c:949)
==3476==    by 0x422EC1: ngx_epoll_process_events (ngx_epoll_module.c:683)
==3476==    by 0x41A1F9: ngx_process_events_and_timers (ngx_event.c:247)
==3476==    by 0x42275A: ngx_single_process_cycle (ngx_process_cycle.c:315)
==3476==  Address 0x4c7bb72 is 34 bytes inside a block of size 4,096 alloc'd
==3476==    at 0x4A074CD: malloc (vg_replace_malloc.c:236)
==3476==    by 0x41D955: ngx_alloc (ngx_alloc.c:22)
==3476==    by 0x40521D: ngx_malloc (ngx_palloc.c:119)
==3476==    by 0x405267: ngx_palloc (ngx_palloc.c:140)
==3476==    by 0x4405AF: ngx_http_upstream_process_header (ngx_http_upstream.c:1538)
==3476==    by 0x43F3A4: ngx_http_upstream_handler (ngx_http_upstream.c:949)
==3476==    by 0x422EC1: ngx_epoll_process_events (ngx_epoll_module.c:683)
==3476==    by 0x41A1F9: ngx_process_events_and_timers (ngx_event.c:247)
==3476==    by 0x42275A: ngx_single_process_cycle (ngx_process_cycle.c:315)
==3476==    by 0x4040E3: main (nginx.c:409)
==3476==  Uninitialised value was created by a heap allocation
==3476==    at 0x4A074CD: malloc (vg_replace_malloc.c:236)
==3476==    by 0x41D955: ngx_alloc (ngx_alloc.c:22)
==3476==    by 0x40521D: ngx_malloc (ngx_palloc.c:119)
==3476==    by 0x405267: ngx_palloc (ngx_palloc.c:140)
==3476==    by 0x4405AF: ngx_http_upstream_process_header (ngx_http_upstream.c:1538)
==3476==    by 0x43F3A4: ngx_http_upstream_handler (ngx_http_upstream.c:949)
==3476==    by 0x422EC1: ngx_epoll_process_events (ngx_epoll_module.c:683)
==3476==    by 0x41A1F9: ngx_process_events_and_timers (ngx_event.c:247)
==3476==    by 0x42275A: ngx_single_process_cycle (ngx_process_cycle.c:315)
==3476==    by 0x4040E3: main (nginx.c:409)
==3476==

Config:

worker_processes  1;
daemon off;
master_process off;
http {
    proxy_cache_path  /tmp/ngx_cache keys_zone=test_cache:10m;
    proxy_temp_path   /tmp/ngx_temp 1 2;
    server {
        listen          1984;
        server_name     _;
        client_max_body_size 30M;
        location /proxy {
            proxy_pass  $scheme://127.0.0.1:$server_port/etc/issue;
            proxy_cache test_cache;
            proxy_cache_valid  1h;
        }
        location = /etc/issue {
            root               /;
        }
    }
}
events {
    worker_connections  64;
}

As I look cachefile, there is six '~' chars (7E above) at the end of first line. You need to have clear cache to see the warning.

This is because writing members of struct ngx_http_file_cache_header_t does not fill its size fully. And therefore nginx writes unitialised bytes at the end of the ngx_http_file_cache_header_t.

With this patch I can silence warning.

--- src/http/ngx_http_file_cache.c-	2013-06-04 21:55:09.000000000 +0300
+++ src/http/ngx_http_file_cache.c	2013-06-04 21:55:44.000000000 +0300
@@ -873,6 +873,8 @@ ngx_http_file_cache_set_header(ngx_http_
     ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
                    "http file cache set header");
 
+    ngx_memzero(h, sizeof(ngx_http_file_cache_header_t));
+
     c = r->cache;
 
     h->valid_sec = c->valid_sec;