Opened 8 years ago

Closed 8 years ago

#1038 closed defect (wontfix)

Nginx doesn't retry to start worker process when fork() error

Reported by: Alexander Golovko Owned by:
Priority: major Milestone:
Component: nginx-core Version: 1.10.x
Keywords: Cc:
uname -a: Linux 393794e71d5c 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt20-1+deb8u3 (2016-01-17) x86_64 GNU/Linux
nginx -V: nginx version: nginx/1.10.1
built by gcc 4.9.2 (Debian 4.9.2-10)
built with OpenSSL 1.0.1k 8 Jan 2015 (running with OpenSSL 1.0.1t 3 May 2016)
TLS SNI support enabled
configure arguments: --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --http-client-body-temp-path=/var/cache/nginx/client_temp --http-proxy-temp-path=/var/cache/nginx/proxy_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --http-uwsgi-temp-path=/var/cache/nginx/uwsgi_temp --http-scgi-temp-path=/var/cache/nginx/scgi_temp --user=nginx --group=nginx --with-http_ssl_module --with-http_realip_module --with-http_addition_module --with-http_sub_module --with-http_dav_module --with-http_flv_module --with-http_mp4_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_random_index_module --with-http_secure_link_module --with-http_stub_status_module --with-http_auth_request_module --with-http_xslt_module=dynamic --with-http_image_filter_module=dynamic --with-http_geoip_module=dynamic --with-http_perl_module=dynamic --add-dynamic-module=debian/extra/njs-1c50334fbea6/nginx --with-threads --with-stream --with-stream_ssl_module --with-http_slice_module --with-mail --with-mail_ssl_module --with-file-aio --with-ipv6 --with-http_v2_module --with-cc-opt='-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2' --with-ld-opt='-Wl,-z,relro -Wl,--as-needed'

Description

If there are not enough memory when nginx reload config, it can't start new workers, but stop old workers. So it listen ports, but doesn't accept connections.

2016/08/02 19:13:52 [alert] 3712#3712: fork() failed while spawning "worker process" (12: Cannot allocate memory).

I think, that it should try to restart worker processes forever, like it do when worker process killed.

Change History (2)

comment:1 by Maxim Dounin, 8 years ago

Restarting worker processes isn't done forever when nginx is able to detect problem like the above, see here:

​http://hg.nginx.org/nginx/file/tip/src/os/unix/ngx_process.c#l533
​http://hg.nginx.org/nginx/file/tip/src/os/unix/ngx_process_cycle.c#l113

Trying to restart processes forever in such fatal situations are likely to cause more harm than good.

comment:2 by Maxim Dounin, 8 years ago

Resolution: → wontfix
Status: new → closed
Note: See TracTickets for help on using tickets.