Opened 7 years ago

Closed 22 months ago

#1255 closed defect (fixed)

map regexp fail to match

Reported by: higuita Owned by:
Priority: minor Milestone:
Component: documentation Version: 1.10.x
Keywords: Cc:
uname -a: Linux jumiaG03 4.7.0-0.bpo.1-amd64 #1 SMP Debian 4.7.5-1~bpo8+2 (2016-10-01) x86_64 GNU/Linux
nginx -V: nginx version: nginx/1.10.3
built with OpenSSL 1.0.2k 26 Jan 2017
TLS SNI support enabled
configure arguments: --with-cc-opt='-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2' --with-ld-opt='-Wl,-z,relro -Wl,-z,now' --prefix=/usr/share/nginx --conf-path=/etc/nginx/nginx.conf --http-log-path=/var/log/nginx/access.log --error-log-path=/var/log/nginx/error.log --lock-path=/var/lock/nginx.lock --pid-path=/run/nginx.pid --modules-path=/usr/lib/nginx/modules --http-client-body-temp-path=/var/lib/nginx/body --http-fastcgi-temp-path=/var/lib/nginx/fastcgi --http-proxy-temp-path=/var/lib/nginx/proxy --http-scgi-temp-path=/var/lib/nginx/scgi --http-uwsgi-temp-path=/var/lib/nginx/uwsgi --with-debug --with-pcre-jit --with-ipv6 --with-http_ssl_module --with-http_stub_status_module --with-http_realip_module --with-http_auth_request_module --with-http_v2_module --with-http_dav_module --with-http_slice_module --with-threads --with-http_addition_module --with-http_flv_module --with-http_geoip_module=dynamic --with-http_gunzip_module --with-http_gzip_static_module --with-http_image_filter_module=dynamic --with-http_mp4_module --with-http_perl_module=dynamic --with-http_random_index_module --with-http_secure_link_module --with-http_sub_module --with-http_xslt_module=dynamic --with-mail=dynamic --with-mail_ssl_module --with-stream=dynamic --with-stream_ssl_module --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/headers-more-nginx-module --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/nginx-auth-pam --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/nginx-cache-purge --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/nginx-dav-ext-module --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/nginx-development-kit --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/nginx-echo --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/ngx-fancyindex --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/nchan --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/nginx-lua --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/nginx-upload-progress --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/nginx-upstream-fair --add-dynamic-module=/build/nginx-4hGAP1/nginx-1.10.3/debian/modules/ngx_http_substitutions_filter_module

Description

I have this code:

map $http_incap_client_ip:$http_incap_tls_version:${http_x_forwarded_proto}:$ssl_protocol $x_forwarded_proto {

default "http";
~[0-9.]*:- "http"; # incapsula http-https connection
~
[0-9.]*:TLSv1 "https"; # incapsula https-https connection
~-:.*:https "https"; # internal tests x-forwarded-proto
~
-:.*:TLSv1 "https"; # internal https connection

}

When i'm trying a local test connection, the log show that $http_incap_client_ip:$http_incap_tls_version:${http_x_forwarded_proto}:$ssl_protocol is:

-:-:https:TLSv1.2

Yet, the $x_forwarded_proto result is http.

Change History (4)

comment:1 by Ruslan Ermilov, 7 years ago

In you case, the $http_incap_* variables do not exist and as such have empty values. It's an undocumented feature of the log module that it outputs them as -.

comment:2 by higuita, 7 years ago

humm... that makes sense! i was fooled by the log

so probably using ~::https should work, i will test.

May i suggest to document this, add to the https://nginx.org/en/docs/http/ngx_http_log_module.html that empty/undefined variables are printed as -, but their value is still empty on all other nginx code.

Thanks for the help

comment:3 by Ruslan Ermilov, 7 years ago

Component: otherdocumentation
Status: newaccepted

comment:4 by Maxim Dounin, 22 months ago

Resolution: fixed
Status: acceptedclosed

It's documented a while ago in b686736680e3/nginx_org. The log_format directive documentation now says:

For default escaping, characters “"”, “\”, and other characters with values less than 32 (0.7.0) or above 126 (1.1.6) are escaped as “\xXX”. If the variable value is not found, a hyphen (“-”) will be logged.

Closing this, thanks to all involved.

Note: See TracTickets for help on using tickets.