Opened 7 years ago

Closed 7 years ago

#1336 closed enhancement (fixed)

pkg-oss: add non-interactive mode to improve scriptability of `build_module.sh`

Reported by: davidjb Owned by: Andrei Belov
Priority: minor Milestone:
Component: nginx-package Version: 1.13.x
Keywords: Cc:
uname -a:
nginx -V: pkg-oss related

Description

The current build_module.sh doesn't have the ability to be run without interaction from the user, making it difficult to run in an automated environment such as a build server or continuous integration environment (eg Travis CI).

There's not much that would need to change, but these are what I've identified so far:

  • The script installs build dependency packages if they are not present. Currently, it runs [yum|apt-get] install [packages...] which will interactively prompt the user for a yes/no response. Passing -y to either of these tools auto-installs packages.
  • The script in turn triggers prepare-build-env in the rpm/SOURCES/Makefile. This interactively prompts the user to confirm removal of the rpmbuild path.

There might also be other areas for DEB-packaging, but I'm only using rpm-based packaging.

It would be extremely helpful if an option like --non-interactive were added that caused -y to be passed to package installation and rm'd the build environment without prompting.

Change History (2)

comment:1 by Andrei Belov, 7 years ago

Component: other → nginx-package
Owner: set to Andrei Belov
Status: new → assigned

comment:2 by Andrei Belov, 7 years ago

Resolution: → fixed
Status: assigned → closed

Fixed by ​http://hg.nginx.org/pkg-oss/rev/e2b3abb6eeb2

Note: See TracTickets for help on using tickets.