sizeof(NGX_INT32_LEN) triggers out of memory

[Vincent Lee]

FILE:nginx/trunk/src/os/win32/ngx_shmem.c, LINES:18

Index: ngx_shmem.c
===================================================================
--- ngx_shmem.c (revision 4567)
+++ ngx_shmem.c (working copy)
@@ -15,7 +15,7 @@

u_char *name;
uint64_t size;

• name = ngx_alloc(shm->name.len + 2 + sizeof(NGX_INT32_LEN), shm->log);

+ name = ngx_alloc(shm->name.len + 2 + NGX_INT32_LEN, shm->log);

if (name == NULL) {

return NGX_ERROR;

}

the NGX_INT32_LEN finger out the length of INT32 string. don't need to sizeof again.
if call sizeof again, ngx_alloc will get a smaller buffer, and then will be out of memory.

[Vincent Lee]

svn path

[Maxim Dounin]

In [4571/nginx]:

(The changeset message doesn't reference this ticket)

[Maxim Dounin]

Fix committed, thanks. Could you please provide proper english transcription of you name (for CHANGES)?

[Vincent Lee]

Replying to Maxim Dounin:

Fix committed, thanks. Could you please provide proper english transcription of you name (for CHANGES)?

i cannot find where to set my english name, it seems that this name is fetched from google+. my english name is vincent.lee, you can call me: vincent. thank you.

[Maxim Dounin]

We usually provide properly capitalized full names in CHANGES. Is "Vincent Lee" looks ok?

[Vincent Lee]

Replying to Maxim Dounin:

We usually provide properly capitalized full names in CHANGES. Is "Vincent Lee" looks ok?

ok,thanks.

[Maxim Dounin]

Thanks, closing this now.