Opened 3 years ago

Closed 3 years ago

#1398 closed defect (fixed)

pkg-oss: add redhat-lsb-core as EL7 dependency for lsb_release

Reported by: davidjb Owned by: Andrei Belov
Priority: minor Milestone:
Component: nginx-package Version: 1.12.x
Keywords: Cc:
uname -a:
nginx -V: nginx version: nginx/1.12.2
built by gcc 4.8.5 20150623 (Red Hat 4.8.5-16) (GCC)
built with OpenSSL 1.0.2k-fips 26 Jan 2017
TLS SNI support enabled
configure arguments: --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib64/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --http-client-body-temp-path=/var/cache/nginx/client_temp --http-proxy-temp-path=/var/cache/nginx/proxy_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --http-uwsgi-temp-path=/var/cache/nginx/uwsgi_temp --http-scgi-temp-path=/var/cache/nginx/scgi_temp --user=nginx --group=nginx --with-compat --with-file-aio --with-threads --with-http_addition_module --with-http_auth_request_module --with-http_dav_module --with-http_flv_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_mp4_module --with-http_random_index_module --with-http_realip_module --with-http_secure_link_module --with-http_slice_module --with-http_ssl_module --with-http_stub_status_module --with-http_sub_module --with-http_v2_module --with-mail --with-mail_ssl_module --with-stream --with-stream_realip_module --with-stream_ssl_module --with-stream_ssl_preread_module --with-cc-opt='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fPIC' --with-ld-opt='-Wl,-z,relro -Wl,-z,now -pie'

Description

The changes introduced at http://hg.nginx.org/pkg-oss/rev/703066617d89 add the call to lsb_release for EL7 systems to check their minor OS version. However, this executable isn't available without having the redhat-lsb-core package installed on the system. In my case, I spotted this as the official CentOS 7 Docker images don't come with this installed.

Could this dependency be specified within the DEVEL_PACKAGES definition within build_module.sh? (eg http://hg.nginx.org/pkg-oss/file/default/build_module.sh#l132). It could be made optional for just EL7.

Change History (3)

comment:1 by Sergey Kandaurov, 3 years ago

Component: othernginx-package

comment:2 by Andrei Belov, 3 years ago

Owner: set to Andrei Belov
Status: newassigned

comment:3 by Andrei Belov, 3 years ago

Resolution: fixed
Status: assignedclosed

Thanks for reporting this.
Fixed in http://hg.nginx.org/pkg-oss/rev/3be6b1835251.

Note: See TracTickets for help on using tickets.