Opened 3 years ago

Closed 3 years ago

#1418 closed defect (invalid)

Allow/Deny don't correctly work with realip_module

Reported by: Veselov Andrey Owned by:
Priority: minor Milestone:
Component: other Version: 1.12.x
Keywords: realip_module access_module Cc:
uname -a: Linux s9ffd145e 2.6.32-042stab125.5 #1 SMP Tue Oct 17 12:48:22 MSK 2017 x86_64 GNU/Linux
nginx -V: nginx version: nginx/1.12.2
built by gcc 4.9.2 (Debian 4.9.2-10)
built with OpenSSL 1.0.1t 3 May 2016
TLS SNI support enabled
configure arguments: --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --http-client-body-temp-path=/var/cache/nginx/client_temp --http-proxy-temp-path=/var/cache/nginx/proxy_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --http-uwsgi-temp-path=/var/cache/nginx/uwsgi_temp --http-scgi-temp-path=/var/cache/nginx/scgi_temp --user=nginx --group=nginx --with-compat --with-file-aio --with-threads --with-http_addition_module --with-http_auth_request_module --with-http_dav_module --with-http_flv_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_mp4_module --with-http_random_index_module --with-http_realip_module --with-http_secure_link_module --with-http_slice_module --with-http_ssl_module --with-http_stub_status_module --with-http_sub_module --with-http_v2_module --with-mail --with-mail_ssl_module --with-stream --with-stream_realip_module --with-stream_ssl_module --with-stream_ssl_preread_module --with-cc-opt='-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC' --with-ld-opt='-Wl,-z,relro -Wl,-z,now -Wl,--as-needed -pie'

Description

http {
...
deny 1.1.1.1;
...
server {
server_name example.com;
...
set_real_ip_from 1.1.1.1;
real_ip_header X-Forwarded-For;
...
}
}

If I send request like
curl -I -H 'X-Forwarded-For: 2.2.2.2' example.com
I get
HTTP/1.1 200 OK

but if I send
curl -I example.com

HTTP/1.1 403 Forbidden

It seems that realip_module runs before access_module and after change $remote_addr access_module works with changed $remote_addr, but not with $realip_remote_addr as expected.

This is a bug or feature?

Change History (2)

comment:1 by Veselov Andrey, 3 years ago

Request was sent from IP 1.1.1.1

Last edited 3 years ago by Veselov Andrey (previous) (diff)

comment:2 by Maxim Dounin, 3 years ago

Resolution: invalid
Status: newclosed

This is how it is expected to work. The set_real_ip_from directive changes the client address for all places where the client address is used, including the access module. It is expected to be used to provide a real client address from a trusted frontend server.

Note: See TracTickets for help on using tickets.