Opened 18 months ago

Closed 18 months ago

Last modified 3 weeks ago

#1542 closed defect (invalid)

gRPC - Variables not allowed in grpc_pass

Reported by: braden.bass@… Owned by:
Priority: minor Milestone:
Component: other Version: 1.13.x
Keywords: Cc:
uname -a: Linux nginx-deployment-6f956f94f9-dx4tc 4.4.111+ #1 SMP Thu Apr 5 21:21:21 PDT 2018 x86_64 GNU/Linux
nginx -V: nginx version: nginx/1.13.12 built by gcc 6.3.0 20170516 (Debian 6.3.0-18+deb9u1) built with OpenSSL 1.1.0f 25 May 2017 TLS SNI support enabled configure arguments: --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --http-client-body-temp-path=/var/cache/nginx/client_temp --http-proxy-temp-path=/var/cache/nginx/proxy_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --http-uwsgi-temp-path=/var/cache/nginx/uwsgi_temp --http-scgi-temp-path=/var/cache/nginx/scgi_temp --user=nginx --group=nginx --with-compat --with-file-aio --with-threads --with-http_addition_module --with-http_auth_request_module --with-http_dav_module --with-http_flv_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_mp4_module --with-http_random_index_module --with-http_realip_module --with-http_secure_link_module --with-http_slice_module --with-http_ssl_module --with-http_stub_status_module --with-http_sub_module --with-http_v2_module --with-mail --with-mail_ssl_module --with-stream --with-stream_realip_module --with-stream_ssl_module --with-stream_ssl_preread_module --with-cc-opt='-g -O2 -fdebug-prefix-map=/data/builder/debuild/nginx-1.13.12/debian/debuild-base/nginx-1.13.12=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC' --with-ld-opt='-specs=/usr/share/dpkg/no-pie-link.specs -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -pie'

Description

We're trying to leverage the grpc pass to route to dynamic set of services based on the incoming sub domain name. It is a mixture of http/json and grpc traffic.

user  nginx;
worker_processes  1;

error_log  /dev/stderr;
pid        /var/run/nginx.pid;


events {
    worker_connections  1024;
}

http {
    log_format  main  '$remote_addr - $remote_user [$time_local] "$request" '
                      '$status $body_bytes_sent "$http_referer" '
                      '"$http_user_agent"';

    server {

        server_name  ~^(?<name>.+)\.example\.com$;
        listen 443 ssl http2;

        ssl_certificate /etc/nginx/ssl/nginx.crt;
        ssl_certificate_key /etc/nginx/ssl/nginx.key;

        access_log /dev/stdout;

        location / {
           resolver 8.8.8.8;

           set $grpctarget grpc://$name.vfe-test.svc.cluster.local;
           set $httptarget http://$name.vfe-test.svc.cluster.local;

           if ($http_content_type = "application/grpc") {
                grpc_pass $grpctarget:11001;
           }
           if ($http_content_type != "application/grpc"){
                proxy_pass $httptarget:11001;
           }
        }
    }
}

The proxy_pass block works fine, but the grpc_pass block fails with:

nginx: [emerg] no port in upstream "$grpctarget" in /etc/nginx/nginx.conf:34

Is this expected? Am I doing something incorrectly? If this isn't supported, is there any work around?

Thanks

Change History (2)

comment:1 Changed 18 months ago by mdounin

  • Resolution set to invalid
  • Status changed from new to closed

Variables are not available in grpc_pass, much like they aren't in memcached_pass. When variables are supported in a particular directive parameter, this is explicitly documented. See, for example, the proxy_pass directive description:

Parameter value can contain variables. In this case...

There is no such clause in the grpc_pass directive description.

If you want nginx to resolve names of upstream servers dynamically, you can use server ... resolve as available in the commercial version.

comment:2 Changed 3 weeks ago by pluknet

See also #1853.

Note: See TracTickets for help on using tickets.