Question on handling NGX_HTTP_CLIENT_CLOSED_REQUEST

[jcornez@…]

Hello and sorry if this is the wrong place to ask about this.

I'm looking at function ngx_http_request in ngx_httprequest.c

and specifically the following block of code.

    if (rc == NGX_ERROR
        || rc == NGX_HTTP_REQUEST_TIME_OUT
        || rc == NGX_HTTP_CLIENT_CLOSED_REQUEST
        || c->error)
    {
        if (ngx_http_post_action(r) == NGX_OK) {
            return;
        }

        ngx_http_terminate_request(r, rc);
        return;
    }

I'm very new to this code base, but it seems there is a chance to not call ngx_http_terminate_request when rc is NGX_HTTP_CLIENT_CLOSED_REQUEST. My understanding is that this is a 499 response indicating that the client has gone away. I think then that one *must* close the socket, else you get CLOSE_WAIT sockets accumulating.

I do have a case where CLOSE_WAIT appears to be accumulating (using the nchan module) and I'm just trying to better understand how this might be possible.

Thank you. Again sorry if this is the wrong forum or if I'm just completely incorrect about what is going on here.

-Jason

[Maxim Dounin]

This particular code always calls ngx_http_terminate_request() unless there is a post_action configured. If there is a post_action, nginx will terminate the request later, after the post action request completes.

In general, a better place to ask questions about nginx code is the ​nginx-devel@ mailing list.