Opened 12 months ago

Closed 11 months ago

Last modified 11 months ago

#2488 closed defect (fixed)

$remote_addr is wrong after quic migration

Reported by: 9649201.quotev.com@… Owned by:
Priority: minor Milestone:
Component: http/3 Version: 1.23.x
Keywords: Cc:
uname -a:
nginx -V: nginx-quic-8347620e0e76

Description

In ngx_quic_set_connection_path(), the address is copied from path->addr_text to c->addr_text. path->addr_text includes the port number, but c->addr_text does not usually include it.

Also, the address may be truncated because it uses min(c->addr_text.len, path->addr_text.len) for the new length.

Change History (4)

comment:1 by Sergey Kandaurov, 12 months ago

Status: new → accepted

comment:2 by Roman Arutyunyan, 12 months ago

Thanks for reporting this. We are now working on improving the issue.

comment:3 by Roman Arutyunyan, 11 months ago

Resolution: → fixed
Status: accepted → closed

Committed fix:

​https://hg.nginx.org/nginx-quic/rev/9462c514a653

comment:4 by Roman Arutyunyan <arut@…>, 11 months ago

In 9099:9462c514a653/nginx:

QUIC: fixed addr_text after migration (ticket #2488).

Previously, the post-migration value of addr_text could be truncated, if
it was longer than the previous one. Also, the new value always included
port, which should not be there.

Note: See TracTickets for help on using tickets.