Changes between Initial Version and Version 1 of Ticket #32


Ignore:
Timestamp:
10/15/11 22:37:58 (10 years ago)
Author:
Maxim Dounin
Comment:

Attached patch fixes the problem (as well as another one with "expires @00h"). The condition in question is correct, but it should go after NGX_HTTP_EXPIRES_DAILY check.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #32

    • Property Owner changed from somebody to Maxim Dounin
    • Property Status newassigned
  • Ticket #32 – Description

    initial v1  
    66the bug is that the expires header is not set correctly when using @
    77and it is the case that it is not set correctly, but you will only see the bug if upstream does not set a last-modified header
     8{{{
    89 if (conf->expires == NGX_HTTP_EXPIRES_ACCESS
    910        || r->headers_out.last_modified_time == -1)
    1011    {
    11 its the || condition that causes the problem
     12}}}
     13its the !|| condition that causes the problem
    1214
    1315