#32 closed defect (fixed)
expires header not set correctly using '@' format
| Reported by: | time4tea.myopenid.com | Owned by: | Maxim Dounin |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | nginx-core | Version: | 1.0.x |
| Keywords: | expires | Cc: | |
| uname -a: | |||
| nginx -V: | |||
Description (last modified by )
If upstream does not send last-modified header, @ style expiry times will be interpreted as (now + time)
(from r1.0.8)
ngx_http_headers_filter_module.c line 266
the bug is that the expires header is not set correctly when using @
and it is the case that it is not set correctly, but you will only see the bug if upstream does not set a last-modified header
if (conf->expires == NGX_HTTP_EXPIRES_ACCESS
|| r->headers_out.last_modified_time == -1)
{
its the || condition that causes the problem
confirmed on #nginx by PiotrSikora
Attachments (1)
Change History (6)
by , 13 years ago
| Attachment: | patch-nginx-expires-daily.txt added |
|---|
comment:1 by , 13 years ago
| Description: | modified (diff) |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:4 by , 13 years ago
I came back to post a patch - but i see i was too slow! - thanks for fixing that!
Note:
See TracTickets
for help on using tickets.
Attached patch fixes the problem (as well as another one with "expires @00h"). The condition in question is correct, but it should go after NGX_HTTP_EXPIRES_DAILY check.