Opened 10 years ago
Closed 9 years ago
Last modified 9 years ago
#355 closed enhancement (fixed)
Proxy protocol support
|Reported by:||Taavi Kald||Owned by:|
|nginx -V:||nginx version: nginx/1.2.7|
Would be nice if Nginx supported Proxy protocol in core: http://haproxy.1wt.eu/download/1.5/doc/proxy-protocol.txt
Found some patches though:
Change History (12)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
+1 We're losing the client's ip if we put haproxy in front of nginx with SSL termination _and_ SPDY support, for that haproxy has to act in TCP mode and can't add an X-Forwarded-For header.
comment:3 by , 10 years ago
+1 similar use case: using aws elb -> nginx on instances which proxy back to various services; used the suggested patch and got mixed results (seems unstable)
comment:4 by , 10 years ago
+1 for this. There is already a solution: https://wiki.bedis.eu/nginx/nginx_proxy_protocol_patch
It would be so great to merge that patch.
comment:5 by , 10 years ago
The patch in question needs to be greatly improved before it can be merged.
comment:6 by , 10 years ago
Is anyone working on getting this integrated? I'd be happy to help. Please let me know what needs to be improved in order to get it merged.
comment:7 by , 10 years ago
+1 for this feature, pretty please, ASAP please.
comment:8 by , 9 years ago
+1 for this feature from me as well. It would be incredibly useful for websocket applications running behind an Amazon ELB, or instances where you need to use an ELB but want SPDY support with your application.
comment:9 by , 9 years ago
+1 from me too.
Nate, I'm not familiar enough with C and nginx to help, but the proxy patch does work but generates _a lot_ of warnings though it works well. Maybe a good first step would be to look into them?
comment:11 by , 9 years ago
|Status:||new → closed|
comment:12 by , 9 years ago
Awesome! I was just about to dive into working on this. Good timing!
+1 on this, Amazon ELBs also support this feature now: