Opened 12 years ago

Closed 11 years ago

#334 closed defect (fixed)

Changeset 5169 breaks building on Debian / Ubuntu

Reported by: Chris Lea Owned by:
Priority: minor Milestone:
Component: nginx-module Version: 1.3.x
Keywords: build, Makefile.PL Cc:
uname -a: Linux test 3.2.0-40-generic #64-Ubuntu SMP Mon Mar 25 21:22:10 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
nginx -V: nginx version: nginx/1.3.16
TLS SNI support enabled
configure arguments: --prefix=/etc/nginx --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-client-body-temp-path=/var/lib/nginx/body --http-fastcgi-temp-path=/var/lib/nginx/fastcgi --http-log-path=/var/log/nginx/access.log --http-proxy-temp-path=/var/lib/nginx/proxy --http-scgi-temp-path=/var/lib/nginx/scgi --http-uwsgi-temp-path=/var/lib/nginx/uwsgi --lock-path=/var/lock/nginx.lock --pid-path=/var/run/nginx.pid --with-pcre-jit --with-http_ssl_module --with-openssl=/build/buildd/nginx-1.3.16/debian/openssl-1.0.1e --without-mail_pop3_module --without-mail_smtp_module --without-mail_imap_module --without-http_uwsgi_module --without-http_scgi_module --with-http_spdy_module --with-ipv6 --with-http_stub_status_module --add-module=/build/buildd/nginx-1.3.16/debian/modules/nginx-upstream-fair --add-module=/build/buildd/nginx-1.3.16/debian/modules/nginx-cache-purge --add-module=/build/buildd/nginx-1.3.16/debian/modules/naxsi/naxsi_src

Description

This change:

​http://trac.nginx.org/nginx/changeset/5169/nginx

breaks the build process when creating .deb packages for Debian / Ubuntu. The build log of a failed build can be seen here:

​https://launchpadlibrarian.net/137578216/buildlog_ubuntu-precise-amd64.nginx_1.3.16-1chl1~precise1_FAILEDTOBUILD.txt.gz

I backed the change out and after that everything built successfully. I haven't had time to figure out exactly what's going wrong, but I wanted to report it sooner than later.

Change History (3)

comment:1 by Maxim Dounin, 12 years ago

Thanks, the following patch should fix this:

--- a/src/http/modules/perl/Makefile.PL
+++ b/src/http/modules/perl/Makefile.PL
@@ -22,7 +22,7 @@ WriteMakefile(
 
     depend => {
         'nginx.c'     => join(" ", map {
-                             "../../../../../$_"
+                             m#^/# ? $_ : "../../../../../$_"
                          } (split(/\s+/, $ENV{NGX_DEPS}),
                             "src/http/modules/perl/ngx_http_perl_module.h"))
     },

comment:2 by Maxim Dounin, 12 years ago

In 5181/nginx:

Configure: fixed perl Makefile generation (ticket #334).

Dependancy tracking introduced in r5169 were not handled absolute path
names properly. Absolute names might appear in CORE_DEPS if --with-openssl
or --with-pcre configure arguments are used to build OpenSSL/PCRE
libraries.

Additionally, revert part of r5169 to set NGX_INCS from Makefile
variables. Makefile variables have $ngx_include_opt in them, which
might result in wrong include paths being used. As a side effect,
this also restores build with --with-http_perl_module and --without-http
at the same time.

comment:3 by Maxim Dounin, 11 years ago

Resolution: → fixed
Status: new → closed

Fixed by [2db6bdcaedc0].

Note: See TracTickets for help on using tickets.