Custom Query (2296 matches)

Hi, using the limit_req_module i've found a possible bug. the variable $limit_req_status is not filled, i guess because the same pointer, (variable) was used to set the http return code directive "limit_req_status code; as wrote in the documentation. unfortunately i'm not a good C devel so i can't provide a working patch. This behavior are present both in the source code compiled and also in the official deb.

I tried to put multiple virtual hosts in the nginx config while enabling quic, but nginx.conf will have validation error if I specify "listen 443 quic resueport" on multiple server blocks:

server {

listen 443 ssl; listen [::]:443 ssl; listen 443 quic reuseport; listen [::]:443 quic reuseport; http2 on; http3 on; http3_hq on; server_name vhost1;

... }

server {

listen 443 ssl; listen [::]:443 ssl; listen 443 quic reuseport; # ----> validation error listen [::]:443 quic reuseport; # ----> validation error http2 on; http3 on; http3_hq on; server_name vhost2;

... }

# nginx -t

nginx: [emerg] duplicate listen options for 0.0.0.0:443 [...]

If I comment out "listen 443 quic reuseport" in the second server block, then http/3 will only work for vhost1, not working for vhost2, even if "http3 on" is used. I tested this using a Chromium-based browser and curl with http3 enabled at compile time (curl3 --http3-only -v -k ​https://ip.address/ -H "Host: vhost2").

On the other hand, removing "reuseport" can let the config pass validation but QUIC connection cannot be established at all, http/3 is not working for neither vhost1 nor vhost2.

The nginx binary is downloaded from ​http://nginx.org/packages/mainline/debian

In nginx-1.23.3/src/http/ngx_http_core_module.c , "ngx_http_set_etag" function adds the "ETag" header to response but does not initialize the header lowcase_key par: "etag->lowcase_key" and not nullify it either so we can't null-check it and know if it is unset in our module code.

I suggest to initialize the lowcase_key while initializing "etag" variable in "ngx_http_set_etag" function and have two options for that

1. etag->lowcase_key= ngx_pnalloc(r->pool, strlen("etag") + 1); strcpy((char*) etag->lowcase_key, "etag");

2. etag->lowcase_key=(u_char*)"etag"; r->headers_out.etag = etag;

I think the first option is safer because we don't cast the string literal const to u_char*

If for some reason bug reviewer thinks we shouldn't init the lowcase_key just nullifying will also help.