Custom Query (2297 matches)

With CentOS 7, the {?dist} macro has changed within spec files from .e7 to .e7.centos. This means that any packages built with the current version of pkg-oss on CentOS 7 have their dependency set on nginx with this dist suffix included like so:

    nginx = 1.12.1-1.el7.centos.ngx

This causes a problem because this dependency is not correct as the EL7 releases for nginx are named like so:

    nginx = 1:1.12.1-1.el7.ngx

The result is that if you try and install a built module whilst having the main nginx yum repo configured, the following failure occurs:

Marking /root/rpmbuild/RPMS/x86_64/nginx-module-shibboleth-debuginfo-1.12.1-1.el7.centos.ngx.x86_64.rpm to be installed
Resolving Dependencies
--> Running transaction check
---> Package nginx-module-shibboleth.x86_64 1:1.12.1-1.el7.centos.ngx will be installed
--> Processing Dependency: nginx = 1:1.12.1-1.el7.centos.ngx for package: 1:nginx-module-shibboleth-1.12.1-1.el7.centos.ngx.x86_64
Loading mirror speeds from cached hostfile
 * base: mirror.intergrid.com.au
 * extras: mirror.aarnet.edu.au
 * updates: mirror.overthewire.com.au
---> Package nginx-module-shibboleth-debuginfo.x86_64 1:1.12.1-1.el7.centos.ngx will be installed
--> Finished Dependency Resolution
Error: Package: 1:nginx-module-shibboleth-1.12.1-1.el7.centos.ngx.x86_64 (/nginx-module-shibboleth-1.12.1-1.el7.centos.ngx.x86_64)
           Requires: nginx = 1:1.12.1-1.el7.centos.ngx
           Available: 1:nginx-1.8.0-1.el7.ngx.x86_64 (nginx)
               nginx = 1:1.8.0-1.el7.ngx
           Available: 1:nginx-1.8.1-1.el7.ngx.x86_64 (nginx)
               nginx = 1:1.8.1-1.el7.ngx
           Available: 1:nginx-1.10.0-1.el7.ngx.x86_64 (nginx)
               nginx = 1:1.10.0-1.el7.ngx
           Available: 1:nginx-1.10.1-1.el7.ngx.x86_64 (nginx)
               nginx = 1:1.10.1-1.el7.ngx
           Available: 1:nginx-1.10.2-1.el7.ngx.x86_64 (nginx)
               nginx = 1:1.10.2-1.el7.ngx
           Available: 1:nginx-1.10.3-1.el7.ngx.x86_64 (nginx)
               nginx = 1:1.10.3-1.el7.ngx
           Available: 1:nginx-1.12.0-1.el7.ngx.x86_64 (nginx)
               nginx = 1:1.12.0-1.el7.ngx
           Available: 1:nginx-1.12.1-1.el7.ngx.x86_64 (nginx)
               nginx = 1:1.12.1-1.el7.ngx
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest

The change stems from ​https://bugs.centos.org/view.php?id=7416 so to fix the issue (or at least workaround it), I've taken to adding the following %define into the pkg-oss's nginx-module.spec.in file:

%if 0%{?rhel} == 7
 [...snip...]
# CentOS 7 specifies dist as ".el7.centos" (https://bugs.centos.org/view.php?id=7416)
# but releases for nginx are just ".el7" so force this.
%define dist .el7
%endif

Could this change be applied to the nginx-module.spec.in file? Thanks.

The changes introduced at ​http://hg.nginx.org/pkg-oss/rev/703066617d89 add the call to lsb_release for EL7 systems to check their minor OS version. However, this executable isn't available without having the redhat-lsb-core package installed on the system. In my case, I spotted this as the official CentOS 7 Docker images don't come with this installed.

Could this dependency be specified within the DEVEL_PACKAGES definition within build_module.sh? (eg ​http://hg.nginx.org/pkg-oss/file/default/build_module.sh#l132). It could be made optional for just EL7.

When trying to build nginx-push-stream-module on Debian (tested on jessie and scratch) with ./build_module.sh -v 1.12.2 -n pushstream -y https://github.com/wandenberg/nginx-push-stream-module.git, I get the following error:

===> Building nginx-module-pushstream package
 dpkg-buildpackage -rfakeroot -D -us -uc
dpkg-buildpackage: warning: using a gain-root-command while being root
dpkg-buildpackage: source package nginx-module-pushstream
dpkg-buildpackage: source version 1.12.2
dpkg-buildpackage: source distribution jessie
dpkg-buildpackage: source changed by Build Script <build.script@example.com>
 dpkg-source --before-build nginx-1.12.2
dpkg-buildpackage: host architecture amd64
 fakeroot debian/rules clean
dh_testdir
dh_testroot
dh_clean
rm -rf /root/debuild/nginx-1.12.2/debian/debuild-module-pushstream/nginx-1.12.2/debian/build-*
find /root/debuild/nginx-1.12.2/debian/debuild-module-pushstream/nginx-1.12.2 -maxdepth 1 -size 0 -delete
 dpkg-source -b nginx-1.12.2
dpkg-source: error: can't build with source format '3.0 (quilt)': non-native package version does not contain a revision
dpkg-buildpackage: error: dpkg-source -b nginx-1.12.2 gave error exit status 255
debuild: fatal error at line 1376:
dpkg-buildpackage -rfakeroot -D -us -uc failed
real 1.12
user 0.75
sys 0.09
Makefile:304: recipe for target 'module-pushstream' failed
make: *** [module-pushstream] Error 29
build_module.sh: ERROR: Build failed

This happens because Debian wants non-native (whatever it means) packages to have a revision number in their version, separated by dash; and the chengelog file created by build_module.sh doesn't have one.

I've fixed it with a simple substitution made before running the script: sed -i -e '/urgency=low/ s/(\${VERSION})/(${VERSION}-1)/' build_module.sh