Opened 7 years ago

Closed 7 years ago

#1156 closed defect (invalid)

Directive access_log needs parameter combined when using with parameter if

Reported by: mmattel@… Owned by:
Priority: minor Milestone:
Component: other Version: 1.9.x
Keywords: Cc:
uname -a: Linux 4.4.0-51-generic #72-Ubuntu SMP Thu Nov 24 18:29:54 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
nginx -V: nginx version: nginx/1.11.6
built by gcc 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4)
built with OpenSSL 1.0.2g 1 Mar 2016
TLS SNI support enabled
configure arguments: --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --http-client-body-temp-path=/var/cache/nginx/client_temp --http-proxy-temp-path=/var/cache/nginx/proxy_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --http-uwsgi-temp-path=/var/cache/nginx/uwsgi_temp --http-scgi-temp-path=/var/cache/nginx/scgi_temp --user=nginx --group=nginx --with-compat --with-file-aio --with-threads --with-http_addition_module --with-http_auth_request_module --with-http_dav_module --with-http_flv_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_mp4_module --with-http_random_index_module --with-http_realip_module --with-http_secure_link_module --with-http_slice_module --with-http_ssl_module --with-http_stub_status_module --with-http_sub_module --with-http_v2_module --with-mail --with-mail_ssl_module --with-stream --with-stream_realip_module --with-stream_ssl_module --with-stream_ssl_preread_module --with-cc-opt='-g -O2 -fstack-protector-strong -Wformat -Werror=format-security' --with-ld-opt='-Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now' --add-module=/opt/nginx-1.11.6/debian/modules/ngx_cache_purge

Description

Creating a conditional access_log according the documentation with if causes an error when parameter combined is not explicitly set.

fail: access_log /path-to-log if=$loggable
works: access_log /path-to-log
works: access_log /path-to-log combined if=$loggable

According the documentation: "If the format is not specified then the predefined “combined” format is used." There is no mentioning for this parameter to be mandatory when using if. Because of predifined, I think this a bug.

Change History (1)

comment:1 by Maxim Dounin, 7 years ago

Resolution: → invalid
Status: new → closed

Syntax of the access_log directive as specified in the ​documentation is as follows:

access_log path [format [buffer=size] [gzip[=level]] [flush=time] [if=condition]];

That is, format is only optional if there are no other parameters are used. This is needed to avoid possible misinterpretation of log format names as parameters and vice versa.

Note: See TracTickets for help on using tickets.