#1354 closed enhancement (wontfix)
add another conditional to nginx.spec.in to support fedora builds
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | nginx-package | Version: | 1.13.x |
Keywords: | Cc: | ||
uname -a: | |||
nginx -V: | nginx version: nginx/1.13.3 |
Description
use_systemd already gets defined for builds on Fedora, so the only other change is to add it to the if block for RHEL 7:
--- ./a/rpm/SPECS/nginx.spec.in +++ ./b/rpm/SPECS/nginx.spec.in @@ -25,7 +25,7 @@ BuildRequires: openssl-devel >= 1.0.1 %endif -%if 0%{?rhel} == 7 +%if 0%{?rhel} == 7 || 0{?fedora} >= 18 %define _group System Environment/Daemons %define epoch 1 Epoch: %{epoch}
Without this, builds fail in a sandboxed environment due to the missing OpenSSL dependency.
Change History (3)
comment:1 by , 7 years ago
comment:2 by , 7 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
We have no plans to build nginx packages for Fedora, so fedora specific changes in spec are redundant.
comment:3 by , 7 years ago
It's an innocuous change that won't affect the releases you do spin, but makes it harder for everyone who uses your SRPMs to build packages for different platforms.
Besides, the %define for use_systemd already contains a conditional that specifically includes Fedora.
Note:
See TracTickets
for help on using tickets.
Oops. That should be "0%{?fedora}"... but you see what I'm saying.