Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#1355 closed defect (invalid)

Can't make 1.13.4 with ngx_pagespeed-latest-stable

Reported by: Jacob Share Owned by:
Priority: minor Milestone:
Component: other Version: 1.13.x
Keywords: Cc:
uname -a: Linux jobmob.co.il 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 19:38:41 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
nginx -V: nginx version: nginx/1.13.3
built by gcc 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4)
built with OpenSSL 1.1.0f 25 May 2017
TLS SNI support enabled
configure arguments: --prefix=/usr/share/nginx --sbin-path=/usr/sbin/nginx --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-client-body-temp-path=/var/lib/nginx/body --http-fastcgi-temp-path=/var/lib/nginx/fastcgi --http-log-path=/var/log/nginx/access.log --http-proxy-temp-path=/var/lib/nginx/proxy --http-scgi-temp-path=/var/lib/nginx/scgi --http-uwsgi-temp-path=/var/lib/nginx/uwsgi --lock-path=/var/lock/nginx.lock --pid-path=/var/run/nginx.pid --with-pcre-jit --with-debug --with-http_addition_module --with-http_dav_module --with-http_geoip_module --with-http_gzip_static_module --with-http_image_filter_module --with-http_realip_module --with-http_stub_status_module --with-http_ssl_module --with-http_sub_module --with-http_xslt_module --with-mail --with-mail_ssl_module --with-http_v2_module --with-threads --add-module=/root/ngx_pagespeed-latest-stable --add-module=/root/ngx_cache_purge-2.3

Description

When I try to make 1.13.4 with ngx_pagespeed-latest-stable using the same modules as in the "nginx -V" here below, the make ends with:

        -o objs/addon/src/ngx_pagespeed.o \
        /root/ngx_pagespeed-latest-stable/src/ngx_pagespeed.cc
/root/ngx_pagespeed-latest-stable/src/ngx_pagespeed.cc: In function ‘ngx_int_t net_instaweb::{anonymous}::ps_preaccess_handler(ngx_http_request_t*)’:
/root/ngx_pagespeed-latest-stable/src/ngx_pagespeed.cc:3011:31: error: ‘ngx_http_core_try_files_phase’ was not declared in this scope
   while (ph[i + 1].checker != ngx_http_core_try_files_phase &&
                               ^
objs/Makefile:1630: recipe for target 'objs/addon/src/ngx_pagespeed.o' failed
make[1]: *** [objs/addon/src/ngx_pagespeed.o] Error 1
make[1]: Leaving directory '/root/temp/nginx-1.13.4'
Makefile:8: recipe for target 'build' failed
make: *** [build] Error 2

Change History (2)

comment:1 by Sergey Kandaurov, 3 years ago

Resolution: invalid
Status: newclosed

It was moved to precontent phase in 1.13.4.
Report to ngx_pagespeed authors instead.

comment:2 by Maxim Dounin, 3 years ago

I would rather recommend to report the whole chunk of the code as a dirty hack which certainly needs rewriting. It also might be a good idea to avoid using a module which does things like this.

Note: See TracTickets for help on using tickets.