Opened 6 years ago

Closed 6 years ago

#1662 closed enhancement (wontfix)

A minor code clean for ngx_configure_listening_sockets

Reported by: chronolaw@… Owned by:
Priority: trivial Milestone:
Component: nginx-core Version: 1.15.x
Keywords: Cc:
uname -a:
nginx -V: nginx version: nginx/1.15.3


At the end of function ngx_configure_listening_sockets, there is a single line 'return;'. It did nothing just remind the code reader here is the end of this function.

Should we remove this line? Pleas see the patch, thanks.

Attachments (1)

ngx_connection.c.patch (531 bytes ) - added by chronolaw@… 6 years ago.

Download all attachments as: .zip

Change History (2)

by chronolaw@…, 6 years ago

Attachment: ngx_connection.c.patch added

comment:1 by Maxim Dounin, 6 years ago

Resolution: wontfix
Status: newclosed

No, thanks. Please avoid pure style changes unless there are other reasons to. Also, please take a look at our recommendations on how to contribute changes, using Trac to submit patches is discouraged.

Note: See TracTickets for help on using tickets.