Opened 4 years ago

Closed 4 years ago

#1939 closed defect (fixed)

Phrasing in doc `ngx_http_limit_req_module`

Reported by: adrian5@… Owned by: Yaroslav Zhuravlev
Priority: minor Milestone:
Component: documentation Version: 1.17.x
Keywords: Cc:
uname -a:
nginx -V: nginx/1.17.3

Description

https://nginx.org/en/docs/http/ngx_http_limit_req_module.html

"If the zone storage is exhausted, the least recently used state is removed. Even if after that a new state cannot be created, the request is terminated with an error."

Unless I misunderstood the intention, I think this should read: "… state is removed. If even after that a new state cannot be created, the …".

"Even if X then Y" → I'll be done anyway.
"If even X then Y" → I'll be done if X fails.

Change History (3)

comment:1 by Yaroslav Zhuravlev, 4 years ago

Status: newaccepted

comment:2 by Yaroslav Zhuravlev, 4 years ago

Owner: set to Yaroslav Zhuravlev
Status: acceptedassigned

comment:3 by Yaroslav Zhuravlev, 4 years ago

Resolution: fixed
Status: assignedclosed

Hi,

Thank you for the feedback, committed:

http://hg.nginx.org/nginx.org/rev/804bcc58f120

Note: See TracTickets for help on using tickets.