Opened 11 years ago
Closed 18 months ago
#458 closed defect (fixed)
Win32: autoindex module doesn't support Unicode names
Reported by: | Kroward 1 | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | nginx-core | Version: | |
Keywords: | win32 | Cc: | |
uname -a: | Microsoft Windows XP [Version 5.1.2600] | ||
nginx -V: | nginx/1.5.8 (current nginx trunk) |
Description
Functions for traversing directories use ANSI versions of FindFirstFile() and FindNextFile(), so any characters in filenames besides basic latin become broken.
Proposed patch fix this issue converting WCHAR names to utf-8.
Attachments (1)
Change History (8)
by , 11 years ago
Attachment: | win32_read_dir.patch added |
---|
comment:1 by , 11 years ago
Status: | new → accepted |
---|
Ack, it needs to be fixed. The patch in question needs more work. (And please also consider reading http://nginx.org/en/docs/contributing_changes.html, thanks.)
comment:2 by , 11 years ago
I forgot to mention than behavior of autoindex module depends on selected charset. The patch does work with 'charset utf-8' directive in config file, but probably will give inconsistent results with other settings.
comment:5 by , 21 months ago
For the record, I've submitted a patch series to address various issues with non-ASCII names on Windows, including this one. In particular, the following patch fixes issues with autoindex:
https://mailman.nginx.org/pipermail/nginx-devel/2023-January/R5C2C6P4QYE2Y4GOHXTZ6VM6PLHARPIE.html
Review and testing appreciated.
comment:7 by , 18 months ago
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
Fix committed and available in nginx 1.23.4 / 1.24.0, closing this. Thanks to all involved.
Win32: WCHAR support it ngx_read_dir() to enable Unicode in autoindex