Opened 9 years ago
Closed 4 weeks ago
#458 closed defect (fixed)
Win32: autoindex module doesn't support Unicode names
|Reported by:||Kroward 1||Owned by:|
|uname -a:||Microsoft Windows XP [Version 5.1.2600]|
|nginx -V:||nginx/1.5.8 (current nginx trunk)|
Functions for traversing directories use ANSI versions of FindFirstFile() and FindNextFile(), so any characters in filenames besides basic latin become broken.
Proposed patch fix this issue converting WCHAR names to utf-8.
Change History (8)
by , 9 years ago
comment:1 by , 9 years ago
|Status:||new → accepted|
Ack, it needs to be fixed. The patch in question needs more work. (And please also consider reading http://nginx.org/en/docs/contributing_changes.html, thanks.)
comment:2 by , 9 years ago
I forgot to mention than behavior of autoindex module depends on selected charset. The patch does work with 'charset utf-8' directive in config file, but probably will give inconsistent results with other settings.
comment:3 by , 6 years ago
See also #1433.
comment:4 by , 2 years ago
See also #2175.
comment:5 by , 5 months ago
For the record, I've submitted a patch series to address various issues with non-ASCII names on Windows, including this one. In particular, the following patch fixes issues with autoindex:
Review and testing appreciated.
comment:6 by , 3 months ago
comment:7 by , 4 weeks ago
|Status:||accepted → closed|
Fix committed and available in nginx 1.23.4 / 1.24.0, closing this. Thanks to all involved.
Win32: WCHAR support it ngx_read_dir() to enable Unicode in autoindex