Opened 9 years ago

Closed 9 years ago

#59 closed enhancement (invalid)

xslt_filter_module - use location root as prefix path for stylesheet

Reported by: sam Owned by: somebody
Priority: minor Milestone:
Component: nginx-module Version: 1.1.x
Keywords: xslt Cc:
uname -a:
nginx -V: 1.1.8

Description

Hi, this simple patch modifies xslt_filter module to make it possible use location (and not server cwd) relative paths in xslt_stylesheet directive.
It should simplify a bit stylesheets deploying.

It's mostly a reorganization patch, stylesheet parsing has been moved to merge handler + fully relative stylesheet paths are being prepended with current location root.
I can improve it if there some problems...

Attachments (1)

nginx-1.1.8-xslt-fix.patch (7.0 KB ) - added by sam 9 years ago.

Download all attachments as: .zip

Change History (2)

by sam, 9 years ago

Attachment: nginx-1.1.8-xslt-fix.patch added

comment:1 by Maxim Dounin, 9 years ago

Resolution: invalid
Status: newclosed

This isn't going to work - "current location root" may be unknown till actual request processing as root (or alias) may contain variables.

Not even talking about backward compatibility and general philosophy (as xslt's are read during configuration parsing, their paths are expected to be resolved either from prefix or from configuration prefix).

BTW, please post further patches into nginx-devel@ mailing list. It is generally much better place for patch review.

Note: See TracTickets for help on using tickets.