Opened 3 years ago

Closed 3 years ago

#1489 closed defect (worksforme)

Document bug/inaccuracy (syntax doc)

Reported by: hawaron@… Owned by:
Priority: minor Milestone:
Component: documentation Version: 1.13.x
Keywords: Cc: eric.yap@…
uname -a: Linux nginx-test 3.10.0-693.11.6.el7.x86_64 #1 SMP Thu Jan 4 01:06:37 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
x86_64 Intel(R) Xeon(R) CPU @ 2.50GHz GenuineIntel GNU/Linux
nginx -V: nginx version: nginx/1.12.2
built by gcc 4.8.5 20150623 (Red Hat 4.8.5-16) (GCC)
built with OpenSSL 1.0.2k-fips 26 Jan 2017
TLS SNI support enabled
configure arguments: --prefix=/usr/share/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib64/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --http-client-body-temp-path=/var/lib/nginx/tmp/client_body --http-proxy-temp-path=/var/lib/nginx/tmp/proxy --http-fastcgi-temp-path=/var/lib/nginx/tmp/fastcgi --http-uwsgi-temp-path=/var/lib/nginx/tmp/uwsgi --http-scgi-temp-path=/var/lib/nginx/tmp/scgi --pid-path=/run/nginx.pid --lock-path=/run/lock/subsys/nginx --user=nginx --group=nginx --with-file-aio --with-ipv6 --with-http_ssl_module --with-http_v2_module --with-http_realip_module --with-http_addition_module --with-http_xslt_module=dynamic --with-http_image_filter_module=dynamic --with-http_geoip_module=dynamic --with-http_sub_module --with-http_dav_module --with-http_flv_module --with-http_mp4_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_random_index_module --with-http_secure_link_module --with-http_degradation_module --with-http_slice_module --with-http_stub_status_module --with-http_perl_module=dynamic --with-mail=dynamic --with-mail_ssl_module --with-pcre --with-pcre-jit --with-stream=dynamic --with-stream_ssl_module --with-google_perftools_module --with-debug --with-cc-opt='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic' --with-ld-opt='-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,-E'

Description

http://nginx.org/en/docs/syntax.html

According to the document above default time value for nginx.conf time values default to seconds when a time suffix is not provided. The default created /etc/nginx/nginx.conf file contains time values that do not have "s" suffix.

Please refer to the following discussion for more context:
https://github.com/voxpupuli/puppet-nginx/issues/1137

Following is extracted from the URL above:


Looking at the nginx source code it seems to me the values are interpreted by default in miliseconds, eg. the source shows:

ngx_conf_merge_msec_value(conf->keepalive_timeout,

prev->keepalive_timeout, 75000);

ngx_conf_merge_msec_value(conf->client_body_timeout,

prev->client_body_timeout, 60000);

ngx_conf_merge_msec_value(conf->send_timeout, prev->send_timeout, 60000);

ngx_conf_merge_msec_value(conf->lingering_timeout,

prev->lingering_timeout, 5000);


Change History (1)

comment:1 by Ruslan Ermilov, 3 years ago

Resolution: worksforme
Status: newclosed

The documentation is correct, time values without the suffix are always interpreted in seconds. Please see the code in ngx_conf_set_msec_slot(), ngx_conf_set_sec_slot(), and the logic behind the last argument is_sec in ngx_parse_time().

Explanation: ngx_parse_time() returns the value either in seconds or milliseconds, depending on the last argument's value. In both cases, the input passed without any suffix is interpreted as a value in second (and gets multiplied by 1000 in case the function is instructed to return milliseconds). That's why you see the default values in milliseconds in ngx_conf_merge_msec_value() calls.

Note: See TracTickets for help on using tickets.